Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Add support for reading text resource format 4 #91250

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

timothyqiu
Copy link
Member

Follow up to #90889.

Basically #89186 without touching VariantWriter::write.

@timothyqiu timothyqiu added enhancement topic:core cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Apr 27, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner April 27, 2024 13:09
@AThousandShips AThousandShips added this to the 4.2 milestone Apr 28, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@akien-mga

This comment was marked as outdated.

@AThousandShips

This comment was marked as outdated.

Co-Authored-By: Gilles Roudiere <gilles.roudiere@gmail.com>
@akien-mga akien-mga merged commit d9bcd1b into godotengine:4.2 Apr 30, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release enhancement topic:core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants